On 2014/06/04 15:02:52, aperez wrote:
On 2014/06/04 11:06:41, marja wrote:
> Cool, I'll have another look when you get PreParser sorted out.
>
> On 2014/06/04 11:02:55, aperez wrote:
>
> > Sounds good to me. Let's try to have this one CL landed first, and
then
> > refactor the checks, as you suggest.
>
> I actually meant the other way around: It would be good if you could
land
the
> refactoring first, so that you don't need to land duplicate code. It
would
make
> this CL smaller, too.
Oh, somehow my brain parsed it the other way around... There is indeed no
problem
in making the refactoring first O:-)
Also, this CL is getting kinda big, and it has both parsing and code
generation
so I will also split the code generation into another CL to make things
easier
to review.
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
