& thanks for comments!

https://codereview.chromium.org/316173002/diff/120001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/316173002/diff/120001/src/accessors.cc#newcode601
src/accessors.cc:601: Object* source =
Script::cast(JSValue::cast(object)->value())->source_url();
On 2014/06/10 09:28:47, yurys wrote:
source -> url

Done.

https://codereview.chromium.org/316173002/diff/120001/src/accessors.cc#newcode636
src/accessors.cc:636: Object* source =
On 2014/06/10 09:28:47, yurys wrote:
ditto

Done.

https://codereview.chromium.org/316173002/diff/120001/src/scanner.cc
File src/scanner.cc (right):

https://codereview.chromium.org/316173002/diff/120001/src/scanner.cc#newcode335
src/scanner.cc:335: } else if
(name_literal.IsEqualTo(STATIC_ASCII_VECTOR("sourceMappingURL"))) {
On 2014/06/10 09:28:47, yurys wrote:
Since we add support for sourceMappingURL we need some tests for it
too (at the
moment we have test coverage only for sourceURL).

Done.

https://codereview.chromium.org/316173002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to