https://codereview.chromium.org/316173002/diff/120001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/316173002/diff/120001/src/accessors.cc#newcode601
src/accessors.cc:601: Object* source =
Script::cast(JSValue::cast(object)->value())->source_url();
source -> url
https://codereview.chromium.org/316173002/diff/120001/src/accessors.cc#newcode636
src/accessors.cc:636: Object* source =
ditto
https://codereview.chromium.org/316173002/diff/120001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/316173002/diff/120001/src/scanner.cc#newcode318
src/scanner.cc:318: // Magic comments are of the form
\s*name\s*=\s*value\s*.* and this function
We might need to allow only single whitespace between @ and sourceURL=
and no space between sourceURL and =:
...@\ssourceURL=\s*...
Personally I'd prefer \s+sourceURL=\s* but it wouldn't match what I see
at
https://blog.getfirebug.com/2009/08/11/give-your-eval-a-name-with-sourceurl/
Vsevolod, what do you think?
https://codereview.chromium.org/316173002/diff/120001/src/scanner.cc#newcode335
src/scanner.cc:335: } else if
(name_literal.IsEqualTo(STATIC_ASCII_VECTOR("sourceMappingURL"))) {
Since we add support for sourceMappingURL we need some tests for it too
(at the moment we have test coverage only for sourceURL).
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
