https://codereview.chromium.org/332443002/diff/1/test/mjsunit/object-literal-computed-names.js
File test/mjsunit/object-literal-computed-names.js (right):
https://codereview.chromium.org/332443002/diff/1/test/mjsunit/object-literal-computed-names.js#newcode26
test/mjsunit/object-literal-computed-names.js:26: var buffer = '/* ' +
(' ' * 4096) + '*/';
(' ' * 4096)
This doesn't do what you think it does.
Do this instead,
Array(4096 + 1).join(' ')
or --harmony_strings and ' '.repeat(4096)
https://codereview.chromium.org/332443002/diff/1/test/mjsunit/object-literal-computed-names.js#newcode47
test/mjsunit/object-literal-computed-names.js:47:
Can you also add a test that ensures that a computed property name that
computes to "__proto__" does not set the [[Prototype]]?
var a = 42;
var b = {['__proto__']: a};
assertEquals(Object.getPrototypeOf(b), Object.prototype);
assertEquals(b.__proto__, a);
assertTrue(b.hasOwnProperty('__proto__'));
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-__proto__-property-names-in-object-initializers
https://codereview.chromium.org/332443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
