On 2014/06/11 19:28:29, arv wrote:
https://codereview.chromium.org/332443002/diff/1/test/mjsunit/object-literal-computed-names.js
File test/mjsunit/object-literal-computed-names.js (right):
https://codereview.chromium.org/332443002/diff/1/test/mjsunit/object-literal-computed-names.js#newcode26
test/mjsunit/object-literal-computed-names.js:26: var buffer = '/* ' +
(' ' *
4096) + '*/';
(' ' * 4096)
This doesn't do what you think it does.
How embarrassing! Thanks for the note.
Can you also add a test that ensures that a computed property name that
computes
to "__proto__" does not set the [[Prototype]]?
Hum, this points out a problem in the patch -- before, the set of
properties in
an object was statically known, and so you could create a new object
literal by
cloning a template and then updating properties that needed to be computed
at
runtime. Now with computed property names that isn't the case. In my
patch we
still create a template for the first few properties -- the ones that
precede
any computed property name -- but subsequent properties are not in the
template.
This of course opens up the possibility of interference from
Object.prototype
:/
I'll have to revise the patch. Thanks again for the feedback, Erik.
https://codereview.chromium.org/332443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
