Revision: 21799
Author: [email protected]
Date: Thu Jun 12 09:40:59 2014 UTC
Log: Remove unnecessary HCompareNumericAndBranch when generating HShr
instruction.
[email protected]
Review URL: https://codereview.chromium.org/334573003
http://code.google.com/p/v8/source/detail?r=21799
Modified:
/branches/bleeding_edge/src/code-stubs-hydrogen.cc
=======================================
--- /branches/bleeding_edge/src/code-stubs-hydrogen.cc Thu Jun 12 07:38:49
2014 UTC
+++ /branches/bleeding_edge/src/code-stubs-hydrogen.cc Thu Jun 12 09:40:59
2014 UTC
@@ -920,20 +920,6 @@
// If we encounter a generic argument, the number conversion is
// observable, thus we cannot afford to bail out after the fact.
if (!state.HasSideEffects()) {
- if (result_type->Is(Type::SignedSmall())) {
- if (state.op() == Token::SHR) {
- // TODO(olivf) Replace this by a SmiTagU Instruction.
- // 0x40000000: this number would convert to negative when
interpreting
- // the register as signed value;
- IfBuilder if_of(this);
- if_of.IfNot<HCompareNumericAndBranch>(result,
- Add<HConstant>(static_cast<int>(SmiValuesAre32Bits()
- ? 0x80000000 : 0x40000000)), Token::EQ_STRICT);
- if_of.Then();
- if_of.ElseDeopt("UInt->Smi oveflow");
- if_of.End();
- }
- }
result = EnforceNumberType(result, result_type);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
