Revision: 21800
Author: [email protected]
Date: Thu Jun 12 09:43:51 2014 UTC
Log: Rename kIs64BitArch with kRequiresCodeRange.
[email protected]
Review URL: https://codereview.chromium.org/335473003
http://code.google.com/p/v8/source/detail?r=21800
Modified:
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/src/globals.h
/branches/bleeding_edge/src/spaces.cc
=======================================
--- /branches/bleeding_edge/src/api.cc Wed Jun 11 14:03:13 2014 UTC
+++ /branches/bleeding_edge/src/api.cc Thu Jun 12 09:43:51 2014 UTC
@@ -465,11 +465,12 @@
set_max_available_threads(i::Max(i::Min(number_of_processors, 4u), 1u));
- if (virtual_memory_limit > 0 && i::kIs64BitArch) {
+ if (virtual_memory_limit > 0 && i::kRequiresCodeRange) {
// Reserve no more than 1/8 of the memory for the code range, but at
most
- // 512 MB.
+ // kMaximalCodeRangeSize.
set_code_range_size(
- i::Min(512, static_cast<int>((virtual_memory_limit >> 3) /
i::MB)));
+ i::Min(i::kMaximalCodeRangeSize / i::MB,
+ static_cast<int>((virtual_memory_limit >> 3) / i::MB)));
}
}
=======================================
--- /branches/bleeding_edge/src/globals.h Tue Jun 3 08:12:43 2014 UTC
+++ /branches/bleeding_edge/src/globals.h Thu Jun 12 09:43:51 2014 UTC
@@ -153,12 +153,14 @@
const int kPointerSizeLog2 = 3;
const intptr_t kIntptrSignBit = V8_INT64_C(0x8000000000000000);
const uintptr_t kUintptrAllBitsSet = V8_UINT64_C(0xFFFFFFFFFFFFFFFF);
-const bool kIs64BitArch = true;
+const bool kRequiresCodeRange = true;
+const int kMaximalCodeRangeSize = 512 * MB;
#else
const int kPointerSizeLog2 = 2;
const intptr_t kIntptrSignBit = 0x80000000;
const uintptr_t kUintptrAllBitsSet = 0xFFFFFFFFu;
-const bool kIs64BitArch = false;
+const bool kRequiresCodeRange = false;
+const int kMaximalCodeRangeSize = 0 * MB;
#endif
const int kBitsPerByte = 8;
=======================================
--- /branches/bleeding_edge/src/spaces.cc Thu Jun 5 12:14:47 2014 UTC
+++ /branches/bleeding_edge/src/spaces.cc Thu Jun 12 09:43:51 2014 UTC
@@ -115,15 +115,17 @@
ASSERT(code_range_ == NULL);
if (requested == 0) {
- // On 64-bit platform(s), we put all code objects in a 512 MB range of
- // virtual address space, so that they can call each other with near
calls.
- if (kIs64BitArch) {
- requested = 512 * MB;
+ // When a target requires the code range feature, we put all code
objects
+ // in a kMaximalCodeRangeSize range of virtual address space, so that
+ // they can call each other with near calls.
+ if (kRequiresCodeRange) {
+ requested = kMaximalCodeRangeSize;
} else {
return true;
}
}
+ ASSERT(requested <= kMaximalCodeRangeSize);
code_range_ = new VirtualMemory(requested);
CHECK(code_range_ != NULL);
if (!code_range_->IsReserved()) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
