Nice, lgtm with some last comments regarding the tests.
If you address those, I'll land.
https://codereview.chromium.org/335683002/diff/20001/test/mjsunit/compiler/inlined-call.js
File test/mjsunit/compiler/inlined-call.js (right):
https://codereview.chromium.org/335683002/diff/20001/test/mjsunit/compiler/inlined-call.js#newcode94
test/mjsunit/compiler/inlined-call.js:94: assertEquals(void 0,
funStrictRecv);
What about just using undefined? :)
https://codereview.chromium.org/335683002/diff/20001/test/mjsunit/compiler/inlined-call.js#newcode120
test/mjsunit/compiler/inlined-call.js:120: assertTrue(this instanceof
Number);
Perhaps also check that it's actually called by doing something like
above where you let the receiver escape? In this case, just write a
value into the global scope?
https://codereview.chromium.org/335683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
