On 2014/06/23 13:59:23, p.antonov wrote:
I don't know how the expression stack is out of sync or
how it could be synced.
Basically, at any deopt point (i.e. any time a potentially deoptimizing
instruction might be introduced, which in particular includes all recursive
VisitForFoo(...) calls), the layout (i.e. both size and contents) of the
expression stack must be the same in full codegen (e.g.
full-codegen-ia32.cc)
and Hydrogen. You can't just call Push()/Pop()/Drop() arbitrarily. If you
carefully trace through the stack's contents at every step in both full
codegen
and hydrogen, you'll find the places where this CL currently violates this
rule.
If/when you re-upload, please do add tests covering those cases.
https://codereview.chromium.org/335683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
