https://codereview.chromium.org/329253004/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/329253004/diff/40001/src/objects-inl.h#newcode6963
src/objects-inl.h:6963: TableType*
table(TableType::cast(iterator->table()));
The use of a raw pointer in a handlified function looks wrong. Can
CurrentKey() just be an instance method instead of a static, and operate
on raw pointers? It doesn't look like it needs to do any allocation.
https://codereview.chromium.org/329253004/diff/40001/src/objects-inl.h#newcode6971
src/objects-inl.h:6971: Handle<Object>
JSMapIterator::CurrentValue(Handle<JSMapIterator> iterator) {
Same as above, but less scary. Seems like this could be an instance
method?
https://codereview.chromium.org/329253004/diff/40001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/329253004/diff/40001/src/runtime.cc#newcode1614
src/runtime.cc:1614: HandleScope scope(isolate);
If you make CurrentKey/CurrentValue instance functions that don't
operate on handles, you should be able to use a SealHandleScope instead
here, which should be slightly faster.
https://codereview.chromium.org/329253004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
