https://codereview.chromium.org/329253004/diff/50001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/329253004/diff/50001/src/objects.cc#newcode16436
src/objects.cc:16436: bool OrderedHashTableIterator<Derived,
TableType>::HasMore(
On 2014/06/16 22:13:57, adamk wrote:
On second reading, does HasMore() ever do allocation? Perhaps it could
be made
an instance method too...though you might want to wait to see if
mstarzinger has
an opinion before doing that.
The only one that does allocation is Next (to create the iterator result
objects).
https://codereview.chromium.org/329253004/diff/50001/src/objects.cc#newcode16444
src/objects.cc:16444: iterator->Transition();
On 2014/06/16 22:13:57, adamk wrote:
This is the only bit that suggests that HasMore uses handles, since
Transition()
uses Handles internally. But looking at the implementation of
Transition() I
think that might be bogus, too (Handles in an instance method are
always
scary-looking, since if the Handles are actually needed to protect
against GC,
|this| could become invalid).
I think I misunderstood this. Only allocations can cause GC. Correct? I
was thinking that clearing references could cause GC but I'm pretty sure
that is not the case any more.
https://codereview.chromium.org/329253004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
