https://codereview.chromium.org/334403003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/334403003/diff/1/include/v8.h#newcode5520
include/v8.h:5520: #if defined (__BYTE_ORDER__) && (__BYTE_ORDER__ ==
__ORDER_BIG_ENDIAN__)
On 2014/06/17 17:11:39, mtbrandy wrote:
I think this is an argument for making the v8-endian definitions
available here
similar to the v8-os definitions. Not all platforms define
__BYTE_ORDER__.
This probably means taking the entire contents of
src/base/build_config.h and putting it in v8config.h. Adding Jochen to
see how that fits into his master plan for refactoring base.
https://codereview.chromium.org/334403003/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/334403003/diff/1/src/hydrogen-instructions.h#newcode6098
src/hydrogen-instructions.h:6098: Map::kInstanceTypeOffset,
On 2014/06/17 16:50:01, Toon Verwaest wrote:
Can we use Map::kInstanceTypeAndBitFieldOffset and define that based
on
endianness?
+1 to Toon's comment
https://codereview.chromium.org/334403003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
