PTAL, got rid of the conditional compilation stuff from patch set 1.
https://codereview.chromium.org/334403003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/334403003/diff/1/include/v8.h#newcode5520
include/v8.h:5520: #if defined (__BYTE_ORDER__) && (__BYTE_ORDER__ ==
__ORDER_BIG_ENDIAN__)
By loading 16 bit word in this API accessor, but only using the LS 8
bits (InstanceType), we can take advantage of the endianess, as Danno
did in r21774. And avoid conditional compilation here.
I think it would be good for the future to bring base/build_config.h
into v8config.h, or at least the CPU arch & endianess part of it, but we
don't need to do it for this issue.
https://codereview.chromium.org/334403003/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/334403003/diff/1/src/hydrogen-instructions.h#newcode6098
src/hydrogen-instructions.h:6098: Map::kInstanceTypeOffset,
Nice suggestion, Toon, it makes it cleaner, and enables the above api
cleanup as well. Done.
https://codereview.chromium.org/334403003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
