Probably ARM would benefit more from extra register. If you plan to
implement
the same for ARM then we can land this.
https://codereview.chromium.org/341863002/diff/1/src/arm64/deoptimizer-arm64.cc
File src/arm64/deoptimizer-arm64.cc (right):
https://codereview.chromium.org/341863002/diff/1/src/arm64/deoptimizer-arm64.cc#newcode53
src/arm64/deoptimizer-arm64.cc:53: patcher.blr(ip0);
Did you mean br(ip0) here?
https://codereview.chromium.org/341863002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/341863002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode845
src/arm64/lithium-codegen-arm64.cc:845: Register entry_offset =
temps.Acquire(ip1);
Nit: maybe introduce a descriptive alias for ip1 to make places that set
it and use it easier to find?
https://codereview.chromium.org/341863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
