Probably ARM would benefit more from extra register. If you plan to
implement
the same for ARM then we can land this.
Yes, ARM ought to benefit much more. I'm not as familiar with the ARM
back-end
in V8, but I believe there are spare registers that we could use. Would you
like
me to prepare the ARM patch before finishing this one?
https://codereview.chromium.org/341863002/diff/1/src/arm64/deoptimizer-arm64.cc
File src/arm64/deoptimizer-arm64.cc (right):
https://codereview.chromium.org/341863002/diff/1/src/arm64/deoptimizer-arm64.cc#newcode53
src/arm64/deoptimizer-arm64.cc:53: patcher.blr(ip0);
On 2014/06/23 11:17:11, ulan wrote:
Did you mean br(ip0) here?
Yes! Thank you.
https://codereview.chromium.org/341863002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/341863002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode845
src/arm64/lithium-codegen-arm64.cc:845: Register entry_offset =
temps.Acquire(ip1);
On 2014/06/23 11:17:11, ulan wrote:
Nit: maybe introduce a descriptive alias for ip1 to make places that
set it and
use it easier to find?
Done.
https://codereview.chromium.org/341863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
