On 2014/06/23 12:11:51, Yang wrote:
The assertions were originally added in [0]. I suspect that they were
supposed
to catch the false negative in [1]: comparing a non-smi int would result in
comparing two heap number constants. In the original implementation, we used
HValue::Equals for equality, which would return false for two distinct
HConstant
values holding the same double value, but in two different heap number
objects.
This has been fixed in [2] that addressed a different, but similar issue.
The
assertions are obsolete since.
[0]
https://codereview.chromium.org/22876009/diff/88001/src/hydrogen-instructions.h
(4133 ff.)
[1]
https://codereview.chromium.org/22876009/diff/88001/src/hydrogen-instructions.cc
(2889 ff.)
[2] https://codereview.chromium.org/195063002/
https://codereview.chromium.org/331863015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
