I can't fathom what those ASSERTs might have been useful for. Either way
they
don't seem to make much sense now, so... LGTM with nits.
https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/regress-crbug-387636.js
File test/mjsunit/regress/regress-crbug-387636.js (right):
https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/regress-crbug-387636.js#newcode1
test/mjsunit/regress/regress-crbug-387636.js:1: // Copyright 2012 the V8
project authors. All rights reserved.
nit: 2014
https://codereview.chromium.org/331863015/diff/20001/test/mjsunit/regress/regress-crbug-387636.js#newcode7
test/mjsunit/regress/regress-crbug-387636.js:7: function f(x) {
nit: what do we need |x| for?
https://codereview.chromium.org/331863015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
