The only changes in the patch set:
- Renaming: AstString -> AstRawString, AstStringBase->AstString
- clang-formatting lines which got too long because of that
- const Vector& -> Vector in ast-value-factory.cc/h
https://codereview.chromium.org/335293004/diff/80001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/335293004/diff/80001/src/ast-value-factory.h#newcode281
src/ast-value-factory.h:281: const AstString* GetOneByteString(const
Vector<const uint8_t>& literal);
On 2014/06/23 13:30:52, rossberg wrote:
On 2014/06/23 11:46:45, marja wrote:
> On 2014/06/23 09:44:27, rossberg wrote:
> > Hm, isn't the idea of the Vector abstraction that this shouldn't
be
necessary?
>
> It's not a huge difference; this will copy the length and the data
pointer
(not
> the actual data); I just got a comment in another code review that I
should
use
> const Vector&; and why not... that's copying one pointer instead of
2.
But you pay with an extra indirection for all uses. Consequently, this
is not
only a micro optimisation, it's one that could actually cost micro
performance.
;)
As you wish. (Changed back to Vector.)
https://codereview.chromium.org/335293004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
