On 2014/06/23 15:29:42, marja wrote:
On 2014/06/23 15:02:32, rossberg wrote:
> LGTM, up to the one comment below that you probably missed. :)
>
>
https://codereview.chromium.org/335293004/diff/230001/src/ast-value-factory.cc
> File src/ast-value-factory.cc (right):
>
>
https://codereview.chromium.org/335293004/diff/230001/src/ast-value-factory.cc#newcode129
> src/ast-value-factory.cc:129: // AstStrings are internalized before
> AstConsStrings so left and right are
> On 2014/06/23 13:30:53, rossberg wrote:
> > Maybe ASSERT that here?
>
> This one.
string() already asserts. I was calling string() on left_ and right_ with
the
purpose of getting this assert asserted.
Is that okay?
Very cool Marja, nicely done!
https://codereview.chromium.org/335293004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
