Reviewers: Michael Achenbach,
Message:
PTAL.
Description:
Sync 'git cl presubmit' and 'tools/presubmit.py'
More precisely, add CheckGeneratedRuntimeTests to checks performed by
'git cl presubmit'.
Please review this at https://codereview.chromium.org/352583005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M PRESUBMIT.py
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index
70f576a81a4de6498eb54c20020219b6cf8ca385..430692f9cafd01354a0afe1da821030ab65ba0d7
100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -41,6 +41,7 @@ def _V8PresubmitChecks(input_api, output_api):
input_api.PresubmitLocalPath(), 'tools'))
from presubmit import CppLintProcessor
from presubmit import SourceProcessor
+ from presubmit import CheckGeneratedRuntimeTests
results = []
if not CppLintProcessor().Run(input_api.PresubmitLocalPath()):
@@ -49,6 +50,9 @@ def _V8PresubmitChecks(input_api, output_api):
results.append(output_api.PresubmitError(
"Copyright header, trailing whitespaces and two empty lines " \
"between declarations check failed"))
+ if not CheckGeneratedRuntimeTests(input_api.PresubmitLocalPath()):
+ results.append(output_api.PresubmitError(
+ "Generated runtime tests check failed"))
return results
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
