Refined the analysis to work for the general case, not just inner function
uses.
However, it's conservative, and marks some stupid cases as possibly-assigned
(e.g., "var x; var x;"). See the test cases.
https://codereview.chromium.org/345573002/diff/1/src/variables.h
File src/variables.h (right):
https://codereview.chromium.org/345573002/diff/1/src/variables.h#newcode84
src/variables.h:84: bool is_assigned_in_inner_function() {
On 2014/06/23 13:03:19, titzer wrote:
may_be_assigned_in_inner_function() ?
Done.
https://codereview.chromium.org/345573002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/345573002/diff/1/test/cctest/test-parsing.cc#newcode2615
test/cctest/test-parsing.cc:2615:
factory->NewStringFromUtf8(i::CStrVector("x")).ToHandleChecked();
On 2014/06/23 13:03:19, titzer wrote:
factory->InternalizeUtf8String()?
Done (also below).
https://codereview.chromium.org/345573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
