Reviewers: marja,
Description:
Revert assertion change from r21933 in Isolate::RunMicrotasks().
[email protected]
Please review this at https://codereview.chromium.org/357453002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -4 lines):
M src/isolate.cc
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index
89052139dfb598e9f2e3fc46b1998a7746f0ecbf..bc23df84b6d3519b92ae1b51b428d3f715eac279
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2292,10 +2292,12 @@ void Isolate::EnqueueMicrotask(Handle<Object>
microtask) {
void Isolate::RunMicrotasks() {
- // In some mjsunit tests %RunMicrotasks is called explicitly, violating
- // this assertion. Therefore we also check for --allow-natives-syntax.
- ASSERT(FLAG_allow_natives_syntax ||
- handle_scope_implementer()->CallDepthIsZero());
+ // TODO(adamk): This ASSERT triggers in mjsunit tests which
+ // call the %RunMicrotasks runtime function. But it should
+ // never happen outside of tests, so it would be nice to
+ // uncomment it.
+ //
+ // ASSERT(handle_scope_implementer()->CallDepthIsZero());
// Increase call depth to prevent recursive callbacks.
v8::Isolate::SuppressMicrotaskExecutionScope suppress(
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
