Reviewers: Sven Panne,
Description:
Drop obsolete dont_optimize compiler hint.
[email protected]
Please review this at https://codereview.chromium.org/354813003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -8 lines):
M src/hydrogen.cc
M src/objects.h
M src/objects-inl.h
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
90e6fbbb19a2b64b265872894ad4b309e27467b8..6a53ea0cc5544f351d125b725cc516cabaddc526
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -7566,7 +7566,7 @@ int
HOptimizedGraphBuilder::InliningAstSize(Handle<JSFunction> target) {
TraceInline(target, caller, "target not inlineable");
return kNotInlinable;
}
- if (target_shared->dont_inline() || target_shared->dont_optimize()) {
+ if (target_shared->dont_inline()) {
TraceInline(target, caller, "target contains unsupported syntax
[early]");
return kNotInlinable;
}
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
e5727c887174086ae23135047d0a5bc8c5d8183e..2b6bdc42d499b30a42ac963c632c27bbff894990
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5388,8 +5388,6 @@ BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints,
BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, bound, kBoundFunction)
BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_anonymous,
kIsAnonymous)
BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_function,
kIsFunction)
-BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_optimize,
- kDontOptimize)
BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_inline,
kDontInline)
BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_cache, kDontCache)
BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, dont_flush, kDontFlush)
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
78776008789821bd67c0741695848bde7162234d..c0110270aba4599b4489e1bc1239489ec7200d56
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7258,9 +7258,6 @@ class SharedFunctionInfo: public HeapObject {
// Is this a function or top-level/eval code.
DECL_BOOLEAN_ACCESSORS(is_function)
- // Indicates that the function cannot be optimized.
- DECL_BOOLEAN_ACCESSORS(dont_optimize)
-
// Indicates that the function cannot be inlined.
DECL_BOOLEAN_ACCESSORS(dont_inline)
@@ -7327,7 +7324,7 @@ class SharedFunctionInfo: public HeapObject {
void set_dont_optimize_reason(BailoutReason reason) {
set_bailout_reason(reason);
- set_dont_optimize(reason != kNoReason);
+ set_dont_inline(reason != kNoReason);
}
// Check whether or not this function is inlineable.
@@ -7473,7 +7470,6 @@ class SharedFunctionInfo: public HeapObject {
kIsAnonymous,
kNameShouldPrintAsAnonymous,
kIsFunction,
- kDontOptimize,
kDontInline,
kDontCache,
kDontFlush,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
