Revision: 22004
Author:   [email protected]
Date:     Wed Jun 25 09:48:49 2014 UTC
Log:      Set OS=android via GYP_DEFINES

Otherwise, the variable isn't available in all scopes. Instead of playing around
with nested scopes, we just set it in GYP_DEFINES (same as chromium does)

BUG=v8:3405
[email protected]
LOG=n

Review URL: https://codereview.chromium.org/357643002
http://code.google.com/p/v8/source/detail?r=22004

Modified:
 /branches/bleeding_edge/Makefile.android
 /branches/bleeding_edge/build/android.gypi

=======================================
--- /branches/bleeding_edge/Makefile.android    Tue Jun 24 07:12:48 2014 UTC
+++ /branches/bleeding_edge/Makefile.android    Wed Jun 25 09:48:49 2014 UTC
@@ -98,6 +98,7 @@

 # For mksnapshot host generation.
 DEFINES += host_os=${HOST_OS}
+DEFINES += OS=android

 .SECONDEXPANSION:
 $(ANDROID_BUILDS): $(OUTDIR)/Makefile.$$@
=======================================
--- /branches/bleeding_edge/build/android.gypi  Fri May 23 16:37:27 2014 UTC
+++ /branches/bleeding_edge/build/android.gypi  Wed Jun 25 09:48:49 2014 UTC
@@ -66,7 +66,6 @@
     'android_stlport_library': 'stlport_static',
     # Copy it out one scope.
     'android_webview_build%': '<(android_webview_build)',
-    'OS': 'android',
   },  # variables
   'target_defaults': {
     'defines': [

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to