2009/10/29 A.Rames <[email protected]>: > > Hi, > > I am ready to contribute the first MIPS patch. > I gave the Corporate Contributor License Agreement to my manager and > should send it soon. > > I have 2 questions before contributing: > > * As this is a patch to begin v8 port to MIPS, I don't know at all who > should review this code. Should I just ask a review at chromium- > [email protected] ?
Better to send it to someone specific. Perhaps me or [email protected]. If we don't have time we can find someone else to do it. I hope you have gcl (the client for codereview.chromium.org) running. > * I am currently working on the port and would like to submit some > specific part of my work, which I think are advanced enough. For the > first patch I'd like to give the assembler-mips files and the very few > modification to architecture independent code (mainly pre-processor > architecture checks to include the right files, and one change about > memory alignment on MIPS). > However I guess it would be nice for you to have other mips files, so > that you can build the shell and easily test the mips assembler. As I > am working on it these are unluckily not very clean, with a lots of > stubs and partly implemented functions. > I prepared a version of the code with very clean assembler-mips files, > and with the JSEntryStub::GenerateBody function just containing a Jump > (ra) to return to v8 code, which could be used to generate code and > test it if you need to. > So do you want me to send you all files or only files needing review? I'd like to see a minimal subset that can actually compile. It doesn't matter that it doesn't run, and it doesn't matter that there are stubbed out functions. I'd like to see some tests that test the bits that you expect to work. If high level tests don't work yet, then a test/cctest/test-assembler-mips.cc file that goes alongside the other assembler test files is the right way to go. I would very much like to see the disassembler and simulator keeping up with the assembler so that the same tests can be run without MIPS hardware. > > Regards. > > Alexandre > > > --~--~---------~--~----~------------~-------~--~----~ v8-users mailing list [email protected] http://groups.google.com/group/v8-users -~----------~----~----~----~------~----~------~--~---
