Oh! It might be because I also use a mercurial repository in the same folder to keep track of my work. I did not think of this. I'll check that.
Thanks, Alexandre On Jan 21, 1:54 pm, Søren Gjesse <[email protected]> wrote: > That looks quite strange. It looks as if gcl tries to use the 'hg' > (Mercurial Distributed SCM) command. If you look at > > http://groups.google.com/group/chromium-dev/browse_thread/thread/e775... > > I would have expected to see 'svn' in place of 'hg' in the error message. > > There is a few mentions of Mercurial on the mailing list > > http://groups.google.com/group/chromium-dev/browse_thread/thread/affc... > > I will suggest that you take a look at GuessVCS/GuessVCSName in > depot_tools/upload.py, to figure out what is happening. > > Regards, > Søren > > On Thu, Jan 21, 2010 at 20:25, Alexandre Rames > <[email protected]>wrote: > > > > > I'm sorry but I don't manage to upload my changes... > > I created a fresh checkout of revision 3220, added mips files and > > modified the other. > > gcl opened seems to indicate everything is fine, but when I try to > > upload I get this error: > > > `--> gcl upload 2ndMIPSCommit > > Got error status from ['hg', 'cat', '-r', 'cd8114d1dfc6', 'test/cctest/ > > test-assembler-mips.cc']: > > > I tried to remove test-assembler-mips.cc but it did not help. Any > > idea? > > > gcl opened outputs the following: > > `--> gcl opened > > --- Changelist 2ndMIPSCommit: > > A test/cctest/test-assembler-mips.cc > > M src/spaces-inl.h > > M src/register-allocator.h > > M src/heap.cc > > M src/codegen-inl.h > > M src/bootstrapper.cc > > M src/flag-definitions.h > > M src/jump-target.cc > > M src/regexp-macro-assembler.cc > > M src/codegen.h > > M src/runtime.js > > M src/virtual-frame.h > > M src/objects.h > > M src/SConscript > > M src/macro-assembler.h > > M src/assembler.h > > M src/v8.cc > > M src/platform-linux.cc > > M src/frames-inl.h > > M src/objects-inl.h > > M src/jump-target.h > > M src/code-stubs.h > > M src/heap.h > > M src/register-allocator-inl.h > > A src/mips > > A src/mips/codegen-mips-inl.h > > A src/mips/ic-mips.cc > > A src/mips/assembler-mips-inl.h > > A src/mips/jump-target-mips.cc > > A src/mips/register-allocator-mips.cc > > A src/mips/codegen-mips.cc > > A src/mips/regexp-macro-assembler-mips.h > > A src/mips/constants-mips.cc > > A src/mips/frames-mips.cc > > A src/mips/virtual-frame-mips.cc > > A src/mips/macro-assembler-mips.h > > A src/mips/frames-mips.h > > A src/mips/disasm-mips.cc > > A src/mips/debug-mips.cc > > A src/mips/cpu-mips.cc > > A src/mips/builtins-mips.cc > > A src/mips/fast-codegen-mips.cc > > A src/mips/readme > > A src/mips/register-allocator-mips.h > > A src/mips/regexp-macro-assembler-mips.cc > > A src/mips/codegen-mips.h > > A src/mips/macro-assembler-mips.cc > > A src/mips/assembler-mips.cc > > A src/mips/test-interface-mips.cc > > A src/mips/stub-cache-mips.cc > > A src/mips/constants-mips.h > > A src/mips/test-mips.cc > > A src/mips/simulator-mips.cc > > A src/mips/test-interface-mips.h > > A src/mips/assembler-mips.h > > A src/mips/virtual-frame-mips.h > > A src/mips/test-mips.h > > A src/mips/simulator-mips.h > > A src/mips/register-allocator-mips-inl.h > > M src/jsregexp.cc > > M src/execution.cc > > M src/globals.h > > M SConstruct > > > On Jan 20, 6:18 pm, Alexandre Rames <[email protected]> wrote: > > > Update: > > > The code has been cleaned and tools/presubmit.py returns with no > > > (significant) errors. > > > So the only work left to do before another commit is to make the mips > > > cctest tests work and check the simulator. > > > > Alexandre > > > > On Jan 20, 3:22 pm, Alexandre Rames <[email protected]> wrote: > > > > > Hi, > > > > > Could you give me some hint on how to run tests I implemented in test- > > > > assembler-mips.cc ? > > > > The file looks like this: > > > > > #include ... > > > > [...] > > > > static void InitializeVM() { [...] } > > > > #define __ assm. > > > > > TEST(MIPS0) { > > > > InitializeVM(); > > > > v8::HandleScope scope; > > > > Assembler assm(NULL, 0); > > > > > // addition > > > > __ addu(v0, a0, Operand(a1)); > > > > __ jr(ra); > > > > __ nop(); > > > > > CodeDesc desc; > > > > assm.GetCode(&desc); > > > > [...] > > > > CHECK_EQ(0xfffffffb, res); > > > > > } > > > > > [...] > > > > > Thanks, > > > > > Alexandre > > > > > On Jan 20, 2:48 pm, Alexandre Rames <[email protected]> wrote: > > > > > > Hi, > > > > > > Thanks for reviewing my code. > > > > > Here are some details and answers on several points. > > > > > > About the contributor licence agreement: I have given it to my boss. > > > > > It will be sent quite soon. > > > > > > I have corrected everything you told, except one issue I detail > > below. > > > > > I hope the fixes will be enough to have it work on a 64bit Linux. I > > > > > don't have one so please let me know of other future errors. > > > > > > I worked on the simulator, the disassembler, and the debugger. (The > > > > > arm code was really helpful. I mainly adapted it.) They all work, but > > > > > the simulator still needs a few tests. However most instructions seem > > > > > to work fine. I am currently working on some tests like the ones in > > > > > test-assembler-<arch>.cc and test-disasm-<arch>.cc . This should be > > > > > done today. Should I commit the code when the tests are implemented? > > > > > There may still be a few mistakes, but there would at least be a good > > > > > basis to work on. > > > > > > About the issue I did not change: > > > > > The concerned review urls are > > > > > http://codereview.chromium.org/549079/diff/1/11#newcode153 > > > > > and http://codereview.chromium.org/549079/diff/1/11#newcode153 > > > > > > I had to use functions with such template when it uses conditional > > > > > execution. > > > > > On MIPS there is 'cmp' instruction or conditional execution like on > > > > > ARM. MIPS assembly has instead contional branch instructions like > > "beq > > > > > r1 r2 offset". > > > > > In MIPS CodeGenerator::Branch function s5 and s6 registers are loaded > > > > > with the values to be compared and the condition is a property of the > > > > > CodeGenerator. I do this because when generating code comparisons are > > > > > done before their result is evaluated to branch. > > > > > However using this kind of solution for other functions would require > > > > > to setup s5 and s6 every time we want to compare something. That > > would > > > > > be really unefficient. > > > > > I can't see another simple way to pass the arguments to functions > > like > > > > > DeferredCodeBranch(). > > > > > We could get rid of the preprocessor #ifdef by using the mips > > template > > > > > for other architectures, which would then not use the extra > > arguments, > > > > > but that would be ugly... > > > > > > Feel free to ask more details if you need. > > > > > > Alexandre > > > -- > > v8-users mailing list > > [email protected] > >http://groups.google.com/group/v8-users -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
