On Thu, Sep 8, 2011 at 06:47, Jakob Kummerow <[email protected]> wrote:
> Update: as of v8 r9196 (will be in version 3.6.2), we have a gyp variable > called soname_version. Setting that to "1.2.3" (e.g. by calling "make -j16 > ia32.release library=shared soname_version=1.2.3", or by putting it into > GYP_DEFINES before manually running gyp) you'll get a > "out/ia32.release/lib.target/libv8-1.2.3.so". > Excellent, that's perfectly fine. Could you update the shared library builder ( http://build.chromium.org/p/client.v8/waterfall?builder=V8%20Linux%20-%20shared) to: 1. Use the gyp build, library=shared 2. Use soname_version (you can pass something dummy there like 0.0.0 or parse V8 version.cc file), to make sure it doesn't break. > I know that this is not a perfect solution, but I hope that it's good > enough. Possible improvements include: > > - detect the version number automatically by analyzing src/version.cc. > I'm not sure whether that would add much value (when a Linux distro builds > a > package, it should know the version of the package anyway, Gentoo ebuilds > do > for sure), nor whether it's desirable, as it would take away some > flexibility. > > Agreed, it's trivial for Gentoo to pass soname_version="${PV}". That's fine. > > - change the naming scheme to libv8.so.1.2.3 as is customary for > libraries. That, however, would require patching GYP to support this (which > I don't feel a particular desire to do). > > Ah okay, so the soname_version switch doesn't affect the name of the resulting library, right? If so, it's fine not to run with soname_version on the buildbot then. We can handle that on the packaging side, that's fine. > I'm happy to include other targets (such as "native"?) into that Makefile. >> Just tell me what you need, or create a patch yourself and I'll gladly >> review it. >> > "make native" sounds good. Could you add it? -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
