How's the best way to test for a performance regression (as in "this test should not hang")? On Sep 23, 2014 1:28 AM, "Ben Noordhuis" <[email protected]> wrote:
> On Tue, Sep 23, 2014 at 1:48 AM, Isiah Meadows <[email protected]> > wrote: > > What I need to do for a specific unit test is to run a specific method + > > arguments, and if it takes too long, stop the call mid-cycle and fail the > > test. This is for a performance-related unit test for my patch (which is > a > > perf patch itself, anyways). Is this possible, and if so, how would I do > it? > > I'm not nearly as well versed in C++ as I am in JavaScript, but I could > > write it in C++ if I had to. > > It sounds like you would need to call V8::TerminateExecution() from a > watchdog thread. That said, tests that rely on wall clock time are > unreliable and will almost certainly get rejected during code review. > > -- > -- > v8-users mailing list > [email protected] > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to a topic in the > Google Groups "v8-users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/v8-users/AMVUNpV-xLw/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
