Maybe I've complicated my question needlessly.

To rephrase, when using custom startup snapshots, via `mksnapshot`, will 
the snapshotted code run slower than the same code loaded from sources at 
runtime?

Thanks,
Alex


On Wednesday, February 14, 2018 at 6:57:38 PM UTC+2, Alexandru Dima wrote:
>
> Hi,
>
> Which one would you recommend we (VSCode) use?
>
> Today, we are using cached data, but I wanted to find out if a startup 
> snapshot would help us more. I've crammed all of VSCode's source code 
> (except third party node modules) in a file and I've created a startup 
> snapshot using `mksnapshot`. I would have thought that the startup snapshot 
> would beat the current cached data usage on startup speed by a long shot...
>
> I was surprised to see that all of the time gains of using a startup 
> snapshot (~200-300ms of code loading) is lost and then some while creating 
> the UI (DOM and stuff...). It looks to me like the code that lives in the 
> startup snapshot is fundamentally slower (50% or 100% slower), and that 
> perhaps it does not use inlining? (see the deep stack traces below).
>
>
> 1. Before (using cached data)
>
>
> https://github.com/Microsoft/vscode/files/1724876/snapshot-before.cpuprofile.txt
>
> https://user-images.githubusercontent.com/5047891/36215842-80a615a2-11ad-11e8-9efc-2d0f2e533e07.png
>
>
> <https://user-images.githubusercontent.com/5047891/36215842-80a615a2-11ad-11e8-9efc-2d0f2e533e07.png>
>
>
>
> 2. After (using startup snapshot)
>
> https://github.com/Microsoft/vscode/files/1724877/snapshot-after.cpuprofile.txt
>
> https://user-images.githubusercontent.com/5047891/36216039-fcd8aa18-11ad-11e8-9bd4-fe4f1add9546.png
>
>
> <https://user-images.githubusercontent.com/5047891/36216039-fcd8aa18-11ad-11e8-9bd4-fe4f1add9546.png>
>
>
> Is this expected? Cached data is always faster than startup snapshot?
>
> We are on an oldish version of v8 (5.8.283.38), as we're using Electron 
> 1.7.9. 
>
> Thanks,
> Alex
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to