On Mon, 2008-03-03 at 17:01 +0100, Julian Seward wrote:
> On Monday 03 March 2008 16:51, Ashley Pittman wrote:
> > I'm trying a VPATH build of valgrind and have found that omega doesn't
> > build when using VPATH, it appears omega is the only tool to try and
> > include pub_core_options.h
>
> Euh, that's a bug. By definition tools are only allowed to see
> include/pub_tool_*.h and not coregrind/anythingatall.h.
>
> You could probably fix this by changing the include to be
> pub_tool_include.h, and then moving any required definitions from
> the core_ to tool_ include files.
>
> But before you do that, have a look at
> http://bugs.kde.org/show_bug.cgi?id=155913
> since that fixes vpath compilation, i believe.
That looks like it should fix it however as you say gives tools full
access to coregrind/*.h
The attached patch should work although the VG_(start_debugger) function
is the only prototype in pub_core_debugger.h so the whole file should
probably be moved to include/pub_tool_debugger.h and the Makefiles
updated accordingly. It's only the two prototypes omega needs to
compile.
Ashley,
Index: exp-omega/o_main.c
===================================================================
--- exp-omega/o_main.c (revision 7545)
+++ exp-omega/o_main.c (working copy)
@@ -58,9 +58,6 @@
#include "pub_tool_options.h"
#include "pub_tool_clreq.h"
-#include "coregrind/pub_core_options.h"
-#include "coregrind/pub_core_debugger.h"
-
#include "libvex_guest_offsets.h"
#include "exp-omega.h"
Index: include/pub_tool_options.h
===================================================================
--- include/pub_tool_options.h (revision 7545)
+++ include/pub_tool_options.h (working copy)
@@ -141,6 +141,14 @@
*/
extern Char* VG_(expand_file_name)(Char* option_name, Char* format);
+/* Enquire about whether to attach to a debugger at errors? default: NO */
+extern Bool VG_(clo_db_attach);
+
+extern void VG_(start_debugger) ( ThreadId tid );
+
+
#endif // __PUB_TOOL_OPTIONS_H
/*--------------------------------------------------------------------*/
Index: coregrind/pub_core_options.h
===================================================================
--- coregrind/pub_core_options.h (revision 7545)
+++ coregrind/pub_core_options.h (working copy)
@@ -48,8 +48,6 @@
default: 0 (no, return the application's exit code in the normal
way. */
extern Int VG_(clo_error_exitcode);
-/* Enquire about whether to attach to a debugger at errors? default: NO */
-extern Bool VG_(clo_db_attach);
/* The debugger command? default: whatever gdb ./configure found */
extern Char* VG_(clo_db_command);
/* Generating a suppression for each error? default: 0 (NO)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Valgrind-developers mailing list
Valgrind-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
