On Sat, Jun 6, 2009 at 4:33 PM, Tim Post<e...@echoreply.us> wrote: > > Sorry if this is the wrong list to post this question.
The valgrind-developers list is arguably more suitable, but this is fine. > 1 - Is syswrap-generic.c (in PRE(sys_ioctl) and POST(sys_ioctl) > respectively) the right place for these? That's where _NR_ioctl is > handled for everything from what I can see. If they should be broken out > into another module, I'll need some guidance :) Looks like you're not looking at the SVN trunk code. You should, see http://www.valgrind.org/downloads/repository.html. PRE/POST(sys_ioctl) are the right functions, but they've moved into syswrap-linux.c. > 2 - I should VKI namespaceize the few constants and structures needed > and add them in include/vki/vki-{arch}.h? I noted the presence of > _VKI_IOC() in both x86 and amd64. Since these aren't coming out of > linux, would it be appropriate to put them in vki-virt-{arch}.h and > include them in vki-{arch}.h ? I would say "yes", but I'm not sure what you mean by "these aren't coming out of linux"? Are they not defined in the kernel headers? > 3 - Is there any reason why these were not added as of yet, i.e. was the > issue of Xen being a moving target a problem? While Xen may add more > ioctls in the future, the existing will not change. No, it'll just be because nobody's complained about them being missing before. > 4 - Where should I post a RFC for the patch prior to creating a bug and > attaching it, or should I just upload it? Just create a bug for it: http://www.valgrind.org/support/bug_reports.html. > It seemed almost too easy, so I want to be sure I'm not missing > something. No, adding new ioctl constants is pretty easy. Nick ------------------------------------------------------------------------------ OpenSolaris 2009.06 is a cutting edge operating system for enterprises looking to deploy the next generation of Solaris that includes the latest innovations from Sun and the OpenSource community. Download a copy and enjoy capabilities such as Networking, Storage and Virtualization. Go to: http://p.sf.net/sfu/opensolaris-get _______________________________________________ Valgrind-users mailing list Valgrind-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/valgrind-users
