On Sat, Jun 6, 2009 at 6:38 PM, Tim Post<e...@echoreply.us> wrote:
>> > 2 - I should VKI namespaceize the few constants and structures needed
>> > and add them in include/vki/vki-{arch}.h? I noted the presence of
>> > _VKI_IOC() in both x86 and amd64. Since these aren't coming out of
>> > linux, would it be appropriate to put them in vki-virt-{arch}.h and
>> > include them in vki-{arch}.h ?
>>
>> I would say "yes", but I'm not sure what you mean by "these aren't
>> coming out of linux"? Are they not defined in the kernel headers?
>
> No, Xen defines them in its own header after including the appropriate
> bits from the kernel. That is why I was considering placing these in a
> separate file. It could be included in vki-{arch}.h anywhere after the
> vki namespaceized types are defined, probably before the first one from
> Linux.
>
> I need 3 structures that depend on 2 others, so I wanted to isolate the
> clutter.
>
> Or, I can just toss them in at the end of each, whichever you'd like.
Hmm, I'd say to just chuck them at the end with an appropriate
explanatory comment.
Nick
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Valgrind-users mailing list
Valgrind-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/valgrind-users
