On Saturday, February 11, 2012, Philippe Waroquiers wrote: > On Fri, 2012-02-10 at 16:01 +0000, Rob wrote: > > Thanks for the patch. I have manually applied it to 3.7.0 (not svn) and > > it is a big improvement. > > > > The number seems to be offset by 1 from what I would expect though, eg. > > --vgdb-error=5 stops after detecting 6 errors. > > Thanks for the feedback. I found the reason for the off by one you have > seen. I will dig deeper in the difference between nr of errors found, and > nr of errors shown. A better patch will follow. > > > One reason for printing the error number in the output would be to avoid > > having to manually count them if there are many. Personally I think it > > would be nicer to always have the errors numbered to help navigating > > large amounts of output . > > I understand this : it is effectively not very easy for the user to count > the error nrs. However, printing an error nr is changing the behaviour for > all tools reporting errors. => changing this implies some advice/feedback > from others > Julian, Bart : an opinion ?
One thing that might be relevant is that errors already have a 32 bit value that identifies them uniquely. "struct _Error :: unique" You can see them in the XML output, eg ./vg-in-place --xml=yes --xml-fd=1 memcheck/tests/errs1 I would prefer to use them, rather than add yet another kind of error-counter mechanism. But the problem is now to show the user what --vgdb-error value is required for each error. The simple thing to do is to print a line Use --vgdb-error=<unique> to make the GDB server stop at this error Problem is I don't really want to add printing of such lines by default. Is it possible that we can make printing of them conditional on some other command line option that must be present in order to use the gdbserver? J ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Valgrind-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/valgrind-users
