On Tue, 23 Sep 2025 19:11:41 GMT, David Beaumont <[email protected]> wrote:
> C++ changes for supporting preview mode when preview mode resources (with new
> location flags) are available.
>
> At the moment, this code will operate on non-preview jimage files (1.0) and
> act as if no preview resources are available by virtue of the default value
> for missing attributes being zero (which matches location flags for "normal"
> entries).
src/hotspot/share/runtime/arguments.cpp line 2088:
> 2086:
> 2087: bool Arguments::disable_preview_patching() {
> 2088: const char* prop = get_property("DISABLE_PREVIEW_PATCHING");
Nitpick, feel free to ignore, esp. since this is temporary. I think it would
make the code easier to follow if this was enable preview patching, defaulting
to true. It stands in contrast to`EnableValhalla` and `enable_preview()`. But
as said, not a huge thing.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1618#discussion_r2418984976
