On Tue, 14 Oct 2025 14:53:24 GMT, Roger Riggs <[email protected]> wrote:
>> I don't use multiple white-space, so this wasn't me. It's just line 113 in >> the old code moved. >> I don't know enough to change it confidently. > > The assert is live, so the comment can be removed. non-empty module name > seems like the correct assertion. name_len and module_name_len are two different things though. The assert for module_name_len is not live. Does module_name_len perhaps mean something in the context of code not in any module? The code below would generate an unobtainable path with '//' in (not present in the jimage, but lookup will progress the same as any other non-existent path). I'll raise a PR for it and see if it can be enabled or (if module names can be empty) be just shortcut and return `0L` if it happens. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1618#discussion_r2429699003
