On Wed, 15 Oct 2025 09:06:56 GMT, Paul Hübner <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reorganising to catch preview-only cases > > src/java.base/share/native/libjimage/jimage.cpp line 115: > >> 113: >> 114: // TBD: assert(module_name_len > 0 && "module name must be >> non-empty"); >> 115: assert(name_len > 0 && "name must non-empty"); > > Nitpick: `assert(expr, msg)` vs `assert(expr && msg)`. I was just copying the existing style for consistency. I'll change everything to the other form if that's considered better. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1618#discussion_r2432517450
