On Thu, 9 Oct 2025 15:56:39 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changing existing package flags during writing to match altered flag
>> values.
>
> src/java.base/share/classes/jdk/internal/jimage/ModuleReference.java line 133:
>
>> 131:
>> 132: /** Returns whether this reference exists only in preview mode. */
>> 133: public boolean isPreviewOnly() {
>
> Pick either PreviewOnly or hasNormal and use consistently. (Even if one is
> the opposite of the other).
They are NOT opposites. It is not possible to use only one or these flags and
continue to be logically correct.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1619#discussion_r2453138935
