On Tue, 28 Oct 2025 20:50:30 GMT, Roger Riggs <[email protected]> wrote:

>> David Beaumont has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   feedback changes
>
> test/jdk/jdk/internal/jimage/ImageReaderTest.java line 1:
> 
>> 1: /*
> 
> It seems odd to only have PreviewMode.DISABLED tests in ImageReaderTest.

That's because the code to write the new entries and generate the flags is in 
the next PR, along with the tests that can now use it.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1619#discussion_r2477857543

Reply via email to