On Tue, 21 Oct 2025 18:57:11 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Rolled up changes after rebase. >> >> * Removing package root flag based on feedback. >> * Changing existing package flags during writing to match altered flag >> values. >> * Feedback changes, and fixing some comments. >> * Renaming slightly confusing "testEncoder" method. >> * Fixing unit tests to use new constructor. >> * Word smithing flags definitions. >> * Add workaround until new image writing code is in >> * Clarifying flag docs for /packages/xxx case >> * Java ImageReader changes for preview mode >> - Merge branch 'jdk_8366093_cpp/squashed' into jdk_8368333_java/squashed >> - [[RESET BRANCH FOR MERGE]] >> - Removing package root flag based on feedback. >> - Changing existing package flags during writing to match altered flag >> values. >> - Feedback changes, and fixing some comments. >> - Test fixes and feedback changes. >> >> * Renaming slightly confusing "testEncoder" method. >> * Fixing unit tests to use new constructor. >> - Manually deleting ImageReaderFactory (it returned somehow) >> - Word smithing flags definitions. >> - Add workaround until new image writing code is in >> - ... and 2 more: >> https://git.openjdk.org/valhalla/compare/64fa0a07...9bbc26c1 > > src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java line 60: > >> 58: public static final int MAJOR_VERSION = 1; >> 59: public static final int MINOR_VERSION = 1; >> 60: private static final int HEADER_SLOTS = 7; > > Please add a comment before these constants connecting them to imageFile.hpp. Done. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1619#discussion_r2477964232
