On Wed, 26 Nov 2025 19:53:13 GMT, Roger Riggs <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove note about StableValue (not possible) > > src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java line > 305: > >> 303: } >> 304: >> 305: private final FileSystemResources sharedResources; > > The fields of JRTIndex should be at the top of the class. > Fields, constructors, static methods, the rest. > There's some debate about where nested classes go (I say at the end). It is worth saying something about the values that are kept here. It looks like a singleton but is per JRTIndex and preview. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1761#discussion_r2566350265
