On Wed, 10 Dec 2025 11:10:45 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java line
>> 147:
>>
>>> 145:
>>> 146: synchronized Entry getEntry(RelativeDirectory rd) throws
>>> IOException {
>>> 147: if (isClosed) {
>>
>> One other example of a new exception, not previously possible. This is
>> rather unavoidable post-closure, and feels like IOException is the
>> appropriate response (as opposed to the IllegalStateException proposed in
>> close()).
>
> I'm not too sure. It seems a case of calling an operation when the object is
> in a bad state. So, ISE or an assertion error seems also legitimate.
Done (ISE).
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1761#discussion_r2622671431
