On Mon, 15 Dec 2025 19:39:16 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> Paul Hübner has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'lworld' into JDK-8373575 >> - Move some tests to Xcomp list. >> - Add failing test to problemlist. >> - Add one of the AOT tests. >> - Problemlist and fix. > > test/jdk/ProblemList-Xcomp.txt line 35: > >> 33: valhalla/valuetypes/ObjectNewInstance.java 8369045 >> macosx-all >> 34: valhalla/valuetypes/ProxyTest.java 8369045 >> macosx-all >> 35: valhalla/valuetypes/WeakReferenceTest.java 8369045 >> macosx-all > > Do these tests only fail with `-Xcomp` when `--enable-preview` is used? > Or do these tests only fail with `-Xcomp` in `lworld` regardless of the > `--enable-preview` value? > > If it's the latter case, then `ProblemList-Xcomp.txt` is the right place. > > Reading through [JDK-8369045](https://bugs.openjdk.org/browse/JDK-8369045), > it sounds like > `--enable-preview` is necessary so I don't think `ProblemList-Xcomp.txt` is > the right place. valhalla/valutypes/ tests add `--enable-preview` so they are going to fail if executed with `-Xcomp` only. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1793#discussion_r2620678648
