On Mon, 15 Dec 2025 21:11:34 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> test/langtools/tools/javap/T4975569.java line 30: >> >>> 28: * @modules jdk.jdeps/com.sun.tools.javap >>> 29: * @modules java.base/jdk.internal.misc >>> 30: * @requires !java.enablePreview >> >> Why is `@requires !java.enablePreview` needed here? The test's `id` value >> is `NoPreview` so that might >> indicate that the test doesn't support `--enable-preview` bits, but I had to >> expand the review's context >> to see that `id` value. > > Another thought occurred to me. Perhaps add a comment line above the > `@requires`: > > @comment Test does not like Valhalla value classes. > > or something like that. I think it would be good if we added a comment > when we use `@requires !java.enablePreview` to indicate which preview > feature is problematic. Added a comment. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1793#discussion_r2622449562
