On Wed, 4 Feb 2026 13:07:53 GMT, David Beaumont <[email protected]> wrote:
> Allow exploded module readers created for exploded system images to support
> preview mode.
src/java.base/share/classes/jdk/internal/module/ModulePath.java line 123:
> 121: * packaged modules. The modules may be patched by the given
> ModulePatcher.
> 122: *
> 123: * <p>This method is deliberately package visible to restrict any
> use of the
I think it would be better to drop the "is deliberately package visible"
comment. The reason the other factory methods are public is that they are
accessed from code in other packages.
src/java.base/share/classes/jdk/internal/module/ModulePath.java line 126:
> 124: * preview mode flag to system modules only.
> 125: */
> 126: static ModuleFinder ofSystem(ModulePatcher patcher, boolean
> previewMode, Path moduleDir) {
I'd prefer name it "of" to be the same as other factory methods.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2032#discussion_r2764558915
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2032#discussion_r2764568854
