On Thu, 19 Feb 2026 11:43:31 GMT, David Beaumont <[email protected]> wrote:
>> test/jdk/jdk/internal/jrtfs/JrtFileSystemClassParityTest.java line 40: >> >>> 38: /* >>> 39: * @test id=normal >>> 40: * @summary A parity test for the default runtime JRT file system. >> >> Would it be possible to get a summary of what you mean by "parity" here? >> This will help with suggestions for how to name this test. > > Changed to: > > * @summary Ensures the default runtime JRT file system has identical behavior > * in packaged or exploded builds. Okay, so the intention is that it tests the file system view of the run-time image with preview classes. Run it with preview features enabled and disabled, and ensure that the .class resources contain the expected class bytes. That's fine. The directory is "jrtfs" so it's clear it's testing jrt-fs, so that will help shorten the name. It would be helpful if the test had "PreviewFeatures" in the name. I think the test summary for the two runs can just focus on testing that the resource contains the class bytes for class compiled with or without preview features. This is because there isn't any notion of "default runtime JRT file system" and the test only runs on the JDK under test (the test has no control over this). Note that testParity (maybe rename to testClassBytes?) shouldn't need to translate IOException. In passing, the make files run the tests with -esa -ea by default so we usually don't need to include these in the test description ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2828371076
