On Tue, 17 Feb 2026 11:19:57 GMT, David Beaumont <[email protected]> wrote:
>> Allow exploded module readers created for exploded system images to support
>> preview mode.
>
> David Beaumont has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Merge branch 'lworld' into jdk_8377162_exploded_modules/squashed
> - revert unnecessary filter in ModulePatcher
> - Latest version
> - Limit awareness of preview resources to system modules only.
>
> * limit preview handling
> * Patch ModuleReaderTest from mainline
> - Preview mode for exploded system module readers
>
> * with better flag plumbing
> * Simpler approach with linked hash set
> * Revert weird import change
> * First cut at a preview aware module reader for exploded builds
> * Test for partiy of JRT file-system and class resources in preview mode
test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java line 179:
> 177: Path previewDir = outDir.resolve("META-INF",
> "preview").resolve(pkgPath);
> 178: Files.createDirectories(previewDir);
> 179: Files.writeString(previewDir.resolve("test.txt"), "Preview
> Version");
The setup for the test is dense. Do you mind putting a blank line before the
comment of each step to make it easier to follow the steps.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2032#discussion_r2823780472
