On Tue, 3 Mar 2026 01:31:07 GMT, David Holmes <[email protected]> wrote:
> Please review these simple changes to some of the JNI functions: > > - JNI `AllocObject` should not throw `InstantiationException` for value types > (and I've added a very simple test for that) > - JNI `NewObject*` had leftover code to explicitly throw > `InstantiationException` but that is already handled inside > `allocate_instance` > > Also fixed some alignment/whitespace issues that had crept in. > > Thanks With the suggested changes to HOTSPOT_JNI_SETOBJECTARRAYELEMENT_ENTRY applied, this looks good to me. ------------- Marked as reviewed by fparain (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2190#pullrequestreview-3882749819
