On Tue, 3 Mar 2026 01:31:07 GMT, David Holmes <[email protected]> wrote:

> Please review these simple changes to some of the JNI functions:
> 
> - JNI `AllocObject` should not throw `InstantiationException` for value types 
> (and I've added a very simple test for that)
> - JNI `NewObject*` had leftover code to explicitly throw 
> `InstantiationException` but that is already handled inside 
> `allocate_instance`
> 
> Also fixed some alignment/whitespace issues that had crept in.
> 
> Thanks

Thanks for the reviews @DanHeidinga , @fparain , @MrSimms  and @walulyai . But 
the changes suggested by @walulyai are unrelated to this PR and would require 
different testing. I filed a follow up issue: 
[JDK-8379151](https://bugs.openjdk.org/browse/JDK-8379151)

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2190#issuecomment-3993722950

Reply via email to