On Mon, 2 Mar 2026 21:50:50 GMT, Roger Riggs <[email protected]> wrote:

> Refactored two tests from TestNG to JUnit.
> Some trivial code cleanup.

test/jdk/java/io/Serializable/valueObjects/SimpleValueGraphs.java line 66:

> 64: import org.junit.jupiter.params.provider.MethodSource;
> 65: 
> 66: @TestInstance(TestInstance.Lifecycle.PER_CLASS)

I usually find this not necessary as long as you make the `@MethodSource` 
target methods static.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2188#discussion_r2881638506

Reply via email to