On Wed, 4 Mar 2026 16:26:12 GMT, Roger Riggs <[email protected]> wrote:
>> Refactored two tests from TestNG to JUnit.
>> Some trivial code cleanup.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed PER_CLASS annotation and made provideers static
Marked as reviewed by liach (Committer).
test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line 258:
> 256: Assertions.assertNull(expected, "Expected exception");
> 257: } catch (IOException ioe) {
> 258: assertEquals(expected, ioe.getClass());
I recommend writing code like this, but it's really optional.
if (expected == null) {
assertDoesNotThrow(() -> deserialize(serialBytes));
} else {
assertThrows(expected, () -> deserialize(serialBytes));
}
-------------
PR Review:
https://git.openjdk.org/valhalla/pull/2188#pullrequestreview-3890750048
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2188#discussion_r2884972897
